Housekeeping: gemspec description, push request device dupe, dead test option#147
Merged
Conversation
… test option - Update gemspec description/summary to mention both Track and Transactional APIs - Remove `device` from SendPushRequest OPTIONAL_FIELDS (already mapped to custom_device) - Remove no-op `json: true` option from test Client initializations
joeybaer
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devicefromSendPushRequest::OPTIONAL_FIELDS— it was already mapped tocustom_devicemanually, causing both keys to appear in the messagejson: trueoption from 5 testClient.newcalls (JSON is always the encoding)Test plan
.gitignorealready hadpkgentry — no change neededNote
Low Risk
Low risk housekeeping changes: updates gem metadata text, removes a duplicated push payload field, and simplifies specs by dropping an unused
json: trueoption without altering core request behavior.Overview
Updates the gemspec
description/summaryto describe support for the Journeys Track and Transactional APIs (instead of only the event API).Fixes
SendPushRequestpayload construction by removingdevicefromOPTIONAL_FIELDSand only mappingopts[:device]intocustom_device, avoiding both keys being sent.Cleans up specs by removing the no-op
json: trueoption from severalCustomerio::Client.newcalls now that JSON encoding is the default.Reviewed by Cursor Bugbot for commit 8f9ca23. Bugbot is set up for automated code reviews on this repo. Configure here.