Skip to content

Housekeeping: gemspec description, push request device dupe, dead test option#147

Merged
hownowstephen merged 1 commit into
mainfrom
cleanup/housekeeping
May 22, 2026
Merged

Housekeeping: gemspec description, push request device dupe, dead test option#147
hownowstephen merged 1 commit into
mainfrom
cleanup/housekeeping

Conversation

@hownowstephen
Copy link
Copy Markdown
Contributor

@hownowstephen hownowstephen commented May 22, 2026

Summary

  • Updated gemspec description/summary to mention both Track and Transactional APIs (was just "event API")
  • Removed device from SendPushRequest::OPTIONAL_FIELDS — it was already mapped to custom_device manually, causing both keys to appear in the message
  • Removed no-op json: true option from 5 test Client.new calls (JSON is always the encoding)

Test plan

  • All 130 examples pass
  • RuboCop clean
  • .gitignore already had pkg entry — no change needed

Note

Low Risk
Low risk housekeeping changes: updates gem metadata text, removes a duplicated push payload field, and simplifies specs by dropping an unused json: true option without altering core request behavior.

Overview
Updates the gemspec description/summary to describe support for the Journeys Track and Transactional APIs (instead of only the event API).

Fixes SendPushRequest payload construction by removing device from OPTIONAL_FIELDS and only mapping opts[:device] into custom_device, avoiding both keys being sent.

Cleans up specs by removing the no-op json: true option from several Customerio::Client.new calls now that JSON encoding is the default.

Reviewed by Cursor Bugbot for commit 8f9ca23. Bugbot is set up for automated code reviews on this repo. Configure here.

… test option

- Update gemspec description/summary to mention both Track and Transactional APIs
- Remove `device` from SendPushRequest OPTIONAL_FIELDS (already mapped to custom_device)
- Remove no-op `json: true` option from test Client initializations
@hownowstephen hownowstephen merged commit f9653b3 into main May 22, 2026
9 checks passed
@hownowstephen hownowstephen deleted the cleanup/housekeeping branch May 22, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants