Skip to content

Support GET requests in Base Client request_class #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishields wants to merge 3 commits into
base: main
Choose a base branch
from
+24 −0
Open

Support GET requests in Base Client request_class #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ae932
Support GET requests in Base Client request_class
ishields Apr 14, 2025
4b54adf
Merge branch 'main' of github.com:customerio/customerio-ruby into sup…
ishields Apr 1, 2026
13cdda7
Add tests for GET support
ishields Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/customerio/base_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ def request_class(method)
Net::HTTP::Put
when :delete
Net::HTTP::Delete
when :get
Net::HTTP::Get
Comment on lines +75 to +76
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GET request support lacks test coverage. Consider adding a test case in spec/base_client_spec.rb similar to the existing tests for PUT requests, to verify that GET requests work correctly with both authentication methods (site_id/api_key and app_key).

Copilot uses AI. Check for mistakes.
else
raise InvalidRequest.new("Invalid request method #{method.inspect}")
end
Expand Down
22 changes: 22 additions & 0 deletions spec/base_client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,28 @@ def api_client_request_headers
end
end

describe "GET requests" do
describe "with a site ID and API key" do
it "sends a GET request with basic auth" do
stub_request(:get, api_uri('/some/path')).
with(headers: track_client_request_headers).
to_return(status: 200, body: "", headers: {})

track_client.request(:get, '/some/path', "")
end
end

describe "with an app key" do
it "sends a GET request with bearer token" do
stub_request(:get, api_uri('/some/path')).
with(headers: api_client_request_headers).
to_return(status: 200, body: "", headers: {})

api_client.request(:get, '/some/path', "")
end
end
end

describe "#verify_response" do
it "throws an error when the response isn't between 200 and 300" do
stub_request(:put, api_uri('/some/path')).
Expand Down