Add userColor3 and userColor4 hat colors#3206
Open
trillium wants to merge 1 commit intocursorless-dev:mainfrom
Open
Add userColor3 and userColor4 hat colors#3206trillium wants to merge 1 commit intocursorless-dev:mainfrom
trillium wants to merge 1 commit intocursorless-dev:mainfrom
Conversation
Add two additional user-configurable hat colors (userColor3, userColor4) to support users who need more than 2 custom colors. Some users configure colors like plum, teal, black, and white, exceeding the current limit of 2 user-defined colors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add userColor3 and userColor4 hat colors
Summary
Add two additional user-configurable hat colors (
userColor3anduserColor4) to Cursorless. Currently only 2 user-defined colors exist (userColor1/navy anduserColor2/apricot), I use 4 colors and as a result am building the extension locally from my personal fork. Would be great if that step wasn't necessary.Changes
userColor3anduserColor4to color enablement defaults and spoken forms (cursorless-talon/src/marks/decorated_mark.py,cursorless-talon/src/spoken_forms.json)HatColorunion type in all legacy command type files (V0V1, V2, V3)cursorless-engine/src/generateSpokenForm/defaultSpokenForms/marks.ts)package.jsonsettings — light/dark color values, hat enablement booleans, hat penalties, and color enum list. Default colors: olive green (#6b8e23) and light gray (#e0e0e0)HAT_COLORSconst array (hatStyles.types.ts)README.mdBoth new colors are disabled by default, matching the pattern of
userColor1/userColor2.Test plan
userColor3anduserColor4in settings and confirm hats render with the configured colorsuserColor3, "black" →userColor4) since the defaults are placeholder names — users must name their colors to use them