Skip to content

Change to use worst Test Step result as the Test Case result#317

Open
brasmusson wants to merge 2 commits intomainfrom
feature/runner-fixes
Open

Change to use worst Test Step result as the Test Case result#317
brasmusson wants to merge 2 commits intomainfrom
feature/runner-fixes

Conversation

@brasmusson
Copy link
Contributor

@brasmusson brasmusson commented Mar 19, 2026

Description

Change to use worst Test Step result as the Test Case result

When calculating the Test Case result Cucumber-Ruby-Core should conform with the GetWorstTestCaseResult function used in the Messages module.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds new behaviour)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Note to other contributors

If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • CHANGELOG.md has been updated

When calculating the Test Case result Cucumber-Ruby-Core should
conform with the GetWorstTestCaseResult function used in the
Messages module.
@luke-hill
Copy link
Contributor

Haven't got round to fully reviewing but we have this concept in messages
https://github.com/cucumber/messages/blob/main/ruby/lib/cucumber/messages/helpers/test_step_result_comparator.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants