Allow zero width BitVecValue#7
Draft
omixann wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Thanks for opening the PR? Is my understanding correct, that the use case for 0-bit values is mostly convenience for users of I think it would be good to support 0-bit widths as long as it isn't too complicated. |
ekiwi
reviewed
May 18, 2026
|
|
||
| #[derive(Clone, Copy, Hash)] | ||
| pub(super) enum BitVecValueRefImpl<'a> { | ||
| Empty, |
Collaborator
There was a problem hiding this comment.
It might be easier to just use Word(0, 0) as connonical empty bit vec.
Author
|
Yes, it is for convenience (e.g., it is rather useful as a base case when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4.
There are a few test cases failing, I'll mark it as ready once I fix them.