Skip to content

use proc_open by default #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomK merged 1 commit into from
Oct 17, 2025
Merged

use proc_open by default #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/Console/Commands/BuiltInWebServer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,25 @@ class BuiltInWebServer extends ConsoleCommand

protected $_executeMethod = 'passthru';

public function __construct($name = null)
{
parent::__construct($name);
$this->_executeMethod = function ($command, &$exitCode) {
if(System::commandExists('bash'))
{
// Use bash to execute if available,
// enables CTRL+C to also kill spawned process (cygwin issue)
$command = ['bash', '-c', $command];
}
$p = proc_open($command, [STDIN, STDOUT, STDERR], $pipes);
if(is_resource($p))
{
$exitCode = proc_close($p);
}
return $exitCode;
};
}

protected function configure()
{
$this->setName('serve');
Expand Down Expand Up @@ -137,12 +156,9 @@ protected function _runCommand($command)
{
$exitCode = 0;
$method = $this->_executeMethod;
if(System::commandExists('bash'))
if(!is_callable($method))
{
// Use bash to execute if available,
// enables CTRL+C to also kill spawned process (cygwin issue)
$command = addcslashes($command, "'");
$command = "bash -c '$command'";
throw new \Exception('method not callable');
}
$method($command, $exitCode);
return $exitCode;
Expand Down