Fix issues when using tap-zendesk#5
Open
micaelbergeron wants to merge 3 commits intocubedevinc:masterfrom
Open
Fix issues when using tap-zendesk#5micaelbergeron wants to merge 3 commits intocubedevinc:masterfrom
micaelbergeron wants to merge 3 commits intocubedevinc:masterfrom
Conversation
added 2 commits
September 26, 2018 15:41
- fix an error when an empty type declaration is found
i.e. "custom": {}
- fix a problem in string sanitization for \u0000
micaelbergeron
commented
Sep 27, 2018
| elif list(v.values())[0][0]['type'] == 'array': | ||
| list(v.values())[0][0]['type'] = ['null', 'array'] | ||
| items.append((new_key, list(v.values())[0][0])) | ||
| property = list(v.values())[0][0] |
Author
There was a problem hiding this comment.
I think this is more readable and efficient.
Remove a print statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues when using
tap-zendeskalongside this target:The discovery of
tap-zendeskoutputs empty property declarations and it caused theflatten_schemafunction to raise an IndexError. Now we ignore these.In a certain entry, I had a
\\u0000sequence that was being escaped twice byjson.dumps. I've simply added some sanitization before sending the CSV line to remove this sequence.