Optimised copy full batches#12
Open
koszti wants to merge 2 commits intocubedevinc:masterfrom
koszti:optimised-copy-full-batches
Open
Optimised copy full batches#12koszti wants to merge 2 commits intocubedevinc:masterfrom koszti:optimised-copy-full-batches
koszti wants to merge 2 commits intocubedevinc:masterfrom
koszti:optimised-copy-full-batches
Conversation
|
👍 this would be great to get in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicating from Binary-Log with incoming UPDATES (hence multiple versions of the row with the same PK) calls intermediate
flush_recordsto avoid issues with upserts.This method works fine but if the replication BinLog has a lot of updates then it produces a lot of unnecessary COPY/INSERT/UPDATE commands with small number of rows which is not efficient.
This PR keeps the incoming rows in python dictionaries where dict key is the Primary Key of the rows. If a new version of the row arrives then it will update the values in the python dictionary without hitting the database.
flush_recordswill be called only when the batch is full and in the last loop.