Fixed multipleOf validation issue: convert float to Decimal#11
Open
koszti wants to merge 2 commits intocubedevinc:masterfrom
koszti:fix/multipleOf-validation-error
Open
Fixed multipleOf validation issue: convert float to Decimal#11koszti wants to merge 2 commits intocubedevinc:masterfrom koszti:fix/multipleOf-validation-error
koszti wants to merge 2 commits intocubedevinc:masterfrom
koszti:fix/multipleOf-validation-error
Conversation
|
I'm running into this so adding my +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing to load floats into Postgres when the values are validated by
"multipleOf": xin the schema. This is reported in issue #6 and I was facing the same problem .The reason is that
multipleOfrequires values as Decimals and we need to convert the input floats to Decimals to work correctly. The idea and the logic is copied from target-stitch