feat(cubesql): Support PatchMeasure for view measures#10571
Open
MazterQyou wants to merge 1 commit intomasterfrom
Open
feat(cubesql): Support PatchMeasure for view measures#10571MazterQyou wants to merge 1 commit intomasterfrom
MazterQyou wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10571 +/- ##
==========================================
- Coverage 83.40% 78.56% -4.84%
==========================================
Files 250 474 +224
Lines 75196 92801 +17605
Branches 0 3611 +3611
==========================================
+ Hits 62718 72913 +10195
- Misses 12478 19343 +6865
- Partials 0 545 +545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR adds support for PatchMeasure member expressions to resolve filters in view measures.
This allows using expressions like
SELECT AVG(CASE dimension WHEN 'value' THEN measure END)on measures in views, not just cubes.Additionally, a new rewrite rule is added to handle simpler syntax:
AGG_FUN(CASE WHEN filter_expr THEN measure END).Related test is included.