Skip to content

fix(query-orchestrator): Use external_id for queue result retrieval t…#10538

Open
ovr wants to merge 7 commits intomasterfrom
feat/query-queue-external-id
Open

fix(query-orchestrator): Use external_id for queue result retrieval t…#10538
ovr wants to merge 7 commits intomasterfrom
feat/query-queue-external-id

Conversation

@ovr
Copy link
Copy Markdown
Member

@ovr ovr commented Mar 23, 2026

…o prevent no-cache query loops

No-cache queries could loop infinitely when multiple clients queried the same SQL near the long polling timeout edge. The root cause was QUEUE RESULT's mark-delete semantics — the first client to retry would consume the result, forcing others to re-execute the query.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.77%. Comparing base (c206026) to head (6142e24).

❗ There is a different number of reports uploaded between BASE (c206026) and HEAD (6142e24). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c206026) HEAD (6142e24)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10538       +/-   ##
===========================================
- Coverage   83.41%   57.77%   -25.64%     
===========================================
  Files         250      223       -27     
  Lines       75150    17526    -57624     
  Branches        0     3607     +3607     
===========================================
- Hits        62683    10125    -52558     
+ Misses      12467     6859     -5608     
- Partials        0      542      +542     
Flag Coverage Δ
cube-backend 57.77% <100.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr marked this pull request as ready for review March 23, 2026 17:49
@ovr ovr requested a review from a team as a code owner March 23, 2026 17:49
@ovr ovr force-pushed the feat/query-queue-external-id branch from bf18608 to 54c1ee8 Compare March 24, 2026 14:36
@ovr ovr requested review from a team as code owners March 24, 2026 14:36
@github-actions github-actions bot added cube store Issues relating to Cube Store rust Pull requests that update Rust code labels Mar 24, 2026
ovr added 6 commits March 24, 2026 17:36
…o prevent no-cache query loops

No-cache queries could loop infinitely when multiple clients queried the same SQL near
the long polling timeout edge. The root cause was QUEUE RESULT's mark-delete semantics —
the first client to retry would consume the result, forcing others to re-execute the query.
chore: fix js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cube store Issues relating to Cube Store data source driver javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant