fix(query-orchestrator): Use external_id for queue result retrieval t…#10538
Open
fix(query-orchestrator): Use external_id for queue result retrieval t…#10538
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #10538 +/- ##
===========================================
- Coverage 83.41% 57.77% -25.64%
===========================================
Files 250 223 -27
Lines 75150 17526 -57624
Branches 0 3607 +3607
===========================================
- Hits 62683 10125 -52558
+ Misses 12467 6859 -5608
- Partials 0 542 +542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bf18608 to
54c1ee8
Compare
…o prevent no-cache query loops No-cache queries could loop infinitely when multiple clients queried the same SQL near the long polling timeout edge. The root cause was QUEUE RESULT's mark-delete semantics — the first client to retry would consume the result, forcing others to re-execute the query.
chore: fix js
0e96be0 to
5865d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o prevent no-cache query loops
No-cache queries could loop infinitely when multiple clients queried the same SQL near the long polling timeout edge. The root cause was QUEUE RESULT's mark-delete semantics — the first client to retry would consume the result, forcing others to re-execute the query.