Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds forceContinueWait optional boolean parameter to /cubesql API endpoint which, when enabled, surfaces Continue wait errors over HTTP transport instead of looping and holding the connection indefinitely.

@github-actions github-actions bot added rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Feb 10, 2026
@MazterQyou MazterQyou force-pushed the backend-native/cubesql-force-continue-wait branch from a98b59e to e8b28db Compare February 10, 2026 12:15
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (159f528) to head (50ee13d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10385       +/-   ##
===========================================
+ Coverage   57.49%   83.29%   +25.80%     
===========================================
  Files         222      250       +28     
  Lines       17334    74697    +57363     
  Branches     3544        0     -3544     
===========================================
+ Hits         9966    62222    +52256     
- Misses       6831    12475     +5644     
+ Partials      537        0      -537     
Flag Coverage Δ
cube-backend ?
cubesql 83.29% <90.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… API endpoint

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou force-pushed the backend-native/cubesql-force-continue-wait branch from e8b28db to 50ee13d Compare February 10, 2026 12:26
@hank-sq
Copy link
Contributor

hank-sq commented Feb 10, 2026

I actually just filed this #10387 - funny timing! Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants