Skip to content

feat: glaze migration and new color system with dark mode#1145

Open
tenphi wants to merge 25 commits into
mainfrom
feat-glaze-integration
Open

feat: glaze migration and new color system with dark mode#1145
tenphi wants to merge 25 commits into
mainfrom
feat-glaze-integration

Conversation

@tenphi
Copy link
Copy Markdown
Member

@tenphi tenphi commented May 5, 2026

Note

Medium Risk
Touches core design tokens and many component default styles (surfaces, shadows, disabled, syntax highlighting), which can cause widespread visual regressions across consuming apps despite aiming for light-mode parity.

Overview
Color system migration: switches palette generation to @tenphi/glaze, introducing scheme-aware tokens (light/@dark/@hc) and new vocabulary like #surface*, #border, #disabled-*, #shadow-*, #overlay, plus per-theme accent and surface token families while keeping legacy token names as aliases.

Component styling updates: replaces many hardcoded #white backgrounds and literal shadow/disabled colors with #surface/$shadow/#disabled-*, tweaks link/hover behavior to use new *-text-soft ramps, updates Tooltip to use #surface-inverse for scheme-invariant dark tooltips, and fixes LoadingAnimation by switching from an img data URI to an inline SVG driven by CSS variables.

Storybook/tooling: adds storybook-dark-mode, bridges the toolbar to <html data-schema> for scheme previews (plus new withColorScheme decorators), brands Storybook themes, disables global backgrounds, removes the Storybook Playground story, bumps Storybook to 10.3.6, updates @tenphi/tasty to 2.6.0, adds pnpm-workspace.yaml build allows, and raises the size-limit budget.

Reviewed by Cursor Bugbot for commit 9bc4675. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cube-ui-kit Ready Ready Preview, Comment May 12, 2026 2:06pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

🦋 Changeset detected

Latest commit: 9bc4675

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

📦 NPM canary release

Deployed canary version 0.0.0-canary-a6d69a9.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🏋️ Size limit report

Name Size Passed?
All 391.24 KB (+3.51% 🔺) Yes 🎉
Tree shaking (just a Button) 112.12 KB (+0.9% 🔺) Yes 🎉

Click here if you want to find out what is changed in this build

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🧪 Storybook is successfully deployed!

Comment thread .storybook/preview.jsx Outdated
@tenphi tenphi changed the title feat: glaze migration and new color system feat: glaze migration and new color system with dark mode May 5, 2026
Comment thread src/data/item-themes.ts
Comment thread src/components/overlays/Tooltip/Tooltip.tsx Outdated
Comment thread src/tokens/colors.ts
tenphi and others added 3 commits May 8, 2026 12:52
The Glaze-driven palette and the Tasty 2.5 update push the gzipped bundle
to 400.37 kB, just over the previous 400 kB limit. Raise the budget to
410 kB so CI passes and there's headroom for the remaining glaze tokens.

Co-authored-by: Cursor <cursoragent@cursor.com>
vitest 4 no longer bundles jsdom transitively. Add it explicitly so
`pnpm test` (and the pre-push hook) can resolve the configured
`environment: 'jsdom'` test environment.

Pinning to ^20.x keeps the previously-working behaviour on this branch;
the jsdom 29 upgrade is being investigated separately on
fix/menutrigger-mobiletype-and-tray.

Co-authored-by: Cursor <cursoragent@cursor.com>
Comment thread pnpm-workspace.yaml Outdated
Comment thread src/components/status/LoadingAnimation/LoadingAnimation.tsx
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4a79276. Configure here.

Comment thread src/version.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants