Tran/set up weekly challenges #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnt07-t
requested review from
Aayush-Agnihotri,
akmatchev and
nfq2
and removed request for
Aayush-Agnihotri
nfq2
requested changes
Nov 25, 2025
Contributor
nfq2
left a comment
nfq2
left a comment
There was a problem hiding this comment.
i left a couple of comments for small fixes. also, since ur changing the database and adding a new table you need to add a migration (tells our database what changes it needs to make). u can prob just ask chatgpt how to do this since i'm not 100% what the commands are but try:
generate migration file: alembic revision --autogenerate -m "add <table>"
syncs ur DB and apply changes to ur db: alembic upgrade head
push the new changes it added to ur branch as well (migrations/versions)
you might also wanna do some testing by creating new challenges and seeing if you can get them using ur endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Added weekly_challenge table and query by date
Overview
Added table weekly_challenge.py in data base and added query get_weekly_challenge_by_date and added but commented out CreateWeeklyChallenge
Changes Made
I populated weekly_challenge table with name, message, start_date, and end_date, added serialize, and added query get_weekly_challenge_by_date
Test Coverage
Tested locally