Skip to content

fix edit capacity logic #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfq2 merged 2 commits into from
Oct 21, 2025
Merged

fix edit capacity logic #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e21853
fix edit capacity reminder logic
nfq2 Oct 20, 2025
7fcdcfe
Merge pull request #218 from cuappdev/nicole/edit-capacity-reminder
nfq2 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,13 +884,13 @@ def mutate(self, info, fcm_token, days_of_week, gyms, capacity_percent):
class EditCapacityReminder(graphene.Mutation):
class Arguments:
reminder_id = graphene.Int(required=True)
gyms = graphene.List(graphene.String, required=True)
new_gyms = graphene.List(graphene.String, required=True)
days_of_week = graphene.List(graphene.String, required=True)
capacity_percent = graphene.Int(required=True)
new_capacity_threshold = graphene.Int(required=True)

Output = CapacityReminder

def mutate(self, info, reminder_id, gyms, days_of_week, capacity_percent):
def mutate(self, info, reminder_id, new_gyms, days_of_week, new_capacity_threshold):
reminder = db_session.query(CapacityReminderModel).filter_by(id=reminder_id).first()
if not reminder:
raise GraphQLError("CapacityReminder not found.")
Expand All @@ -904,10 +904,10 @@ def mutate(self, info, reminder_id, gyms, days_of_week, capacity_percent):
raise GraphQLError(f"Invalid day of the week: {day}")

# Validate gyms
valid_gyms = []
for gym in gyms:
new_valid_gyms = []
for gym in new_gyms:
try:
valid_gyms.append(CapacityReminderGymGraphQLEnum[gym].value)
new_valid_gyms.append(CapacityReminderGymGraphQLEnum[gym].value)
except KeyError:
raise GraphQLError(f"Invalid gym: {gym}")

Expand All @@ -925,7 +925,7 @@ def mutate(self, info, reminder_id, gyms, days_of_week, capacity_percent):
raise GraphQLError(f"Error subscribing to topic: {error}")

# Subscribe to new reminders
topics = [f"{gym}_{day}_{reminder.capacity_threshold}" for gym in valid_gyms for day in validated_workout_days]
topics = [f"{gym}_{day}_{new_capacity_threshold}" for gym in new_valid_gyms for day in validated_workout_days]

for topic in topics:
try:
Expand All @@ -935,9 +935,9 @@ def mutate(self, info, reminder_id, gyms, days_of_week, capacity_percent):
except Exception as error:
raise GraphQLError(f"Error subscribing to topic: {error}")

reminder.gyms = valid_gyms
reminder.gyms = new_valid_gyms
reminder.days_of_week = validated_workout_days
reminder.capacity_threshold = capacity_percent
reminder.capacity_threshold = new_capacity_threshold

db_session.commit()
return reminder
Expand Down
Loading