Text field refactor/richie #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinnie4k
approved these changes
Nov 9, 2023
Collaborator
vinnie4k
left a comment
vinnie4k
left a comment
There was a problem hiding this comment.
I just glanced over it but make sure you change [self] to [unowned self] to prevent memory leaks when using a reference of self inside of a closure. Otherwise good to go.
| setupTitle(name: "About you") | ||
|
|
||
| nextAction = UIAction { _ in | ||
| nextAction = UIAction { [self] _ in |
Collaborator
There was a problem hiding this comment.
Change [self] to [unowned self]
|
|
||
| return | ||
| } | ||
| nextAction = UIAction { [self] _ in |
Collaborator
There was a problem hiding this comment.
Change [self] to [unowned self]
|
|
||
| guard let phoneNumber = self.numberTextField.textField.text, self.validateNumber(value: phoneNumber) else { | ||
| self.presentErrorAlert(title: "Error", message: "Please enter a valid phone number.") | ||
| self.numberTextField.displayError() |
Collaborator
There was a problem hiding this comment.
Make sure you retain an [unowned self]
| // MARK: Using OnboardingViewController's views | ||
|
|
||
| nextAction = UIAction { _ in | ||
| nextAction = UIAction { [self] _ in |
| guard let arrival = arrivalTextField.textField.text, !arrival.isEmpty, | ||
| let departure = departureTextField.textField.text, !departure.isEmpty, | ||
| studentDriverButton.isSelected || taxiButton.isSelected | ||
| else { return } |
Collaborator
There was a problem hiding this comment.
Put else on the line above
|
|
||
| func textFieldShouldReturn(_ textField: UITextField) -> Bool { | ||
| textField.endEditing(true) | ||
| } |
| text = placeholder | ||
| } | ||
|
|
||
| if let error = error { |
tiffany-pann
approved these changes
Nov 11, 2023
Contributor
tiffany-pann
left a comment
tiffany-pann
left a comment
There was a problem hiding this comment.
Very very nice ( •̀ ω •́ )✧
| func setup(title: String, placeholder: String? = nil) { | ||
| func setup(title: String, placeholder: String? = nil, error: String? = nil) { | ||
| var text = title | ||
| var errorText = "Please complete this field." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes Made
LabeledTextField Added Finite States: (View FSM Below)
a. Has Text: Show label in black, border is black color and border width 1px
b. No Text: Show label in mutedGrey, border is mutedGrey color and displays placeholder text, border width 1px
Refactored and updated interactivity for textFields in the following VCs
Screenshots (delete if not applicable)
Error States:
