Conversation
Contributor
pbchase
commented
Mar 25, 2026
pbchase
commented
- Update label counts.
- Add "Test print" feature
There was a problem hiding this comment.
Pull request overview
Adds a “Test print” mode to the Zebra label printing workflow and adjusts the generated label counts/sample set, updating UI strings and documentation accordingly.
Changes:
- Add a conditional Test print button (shown when
@ZEBRA-LABEL-PRINTER="test") that prints a reduced label set. - Parse the action tag’s value server-side and pass it to the client to drive the conditional UI.
- Update sample label definitions/counts in
generateLabelArray.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lang/English.ini | Adds localized label for the new “Test print” button. |
| js/generateTubeLabels.js | Adds conditional “Test print” button and shared print handler with reduced-label logic. |
| js/generateTubeLabels.bundle.js | Rebuilt bundle reflecting the updated JS behavior. |
| README.md | Fixes a typo and documents the new “Test printing” feature. |
| ExternalModule.php | Adds action-tag value parsing, passes tagValue to JS, and updates label counts/sample definitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Disable both print buttons for the duration of a print operation to prevent overlapping printer jobs. Add test printing documentation to the README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.