This repository was archived by the owner on Jun 3, 2019. It is now read-only.
Use mini-css-extract instead of extract-text-plugin#569
Open
diondirza wants to merge 1 commit intoctrlplusb:nextfrom
Open
Use mini-css-extract instead of extract-text-plugin#569diondirza wants to merge 1 commit intoctrlplusb:nextfrom
diondirza wants to merge 1 commit intoctrlplusb:nextfrom
Conversation
diondirza
force-pushed
the
mini-css-extract
branch
from
3342626 to
5a6df5c
Compare
|
I think this is a great idea as long as it can support having a global css and css modules. I'm assuming if you put an import in a top level component (and don't use css modules in webpack) that would solve the global problem. Will this just work out of the box with import() and react-async-component? How cool. |
Contributor
|
@diondirza @unleashit how is this working out for you so far? Good to merge or are there known issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using mini-css-extract plugin improve our page load time, since css will be trimmed per view usage, instead of load big chunk unused style in single css file its better to have css loaded on demand, based on page view