Ctrlplane init ctrlplane.yaml support
#741
Closed
+87
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change standardizes all Go templating variables across the system
to use lowercase consistently (e.g., {{.resource.name}}) instead of the
previous inconsistent casing.
Changes:
- Added Map() method to TemplatableJob that converts the struct to a
map[string]any using JSON marshaling, ensuring consistent lowercase
field names as defined by JSON tags
- Updated ArgoCD dispatcher to use Map() for template execution
- Updated Terraform Cloud dispatcher to use Map() for template execution
- Updated all related tests to use lowercase template variables
This brings ArgoCD/Terraform templating in line with verification
templating which already used lowercase variables.
Closes #738
Co-authored-by: justin <justin@wandb.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize Go templating variable casing to lowercase across all templating surfaces.
Previously, Go templating variables had inconsistent casing (e.g.,
{{.Resource.Name}}in ArgoCD vs.{{.resource.name}}in verification), leading to confusion and potential errors. This change standardizes all templatable variables to lowercase for consistency.