Ctrlplane init ctrlplane.yaml support
#740
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change standardizes all Go templating variables across templating surfaces to use lowercase consistently, as proposed in issue #738. Changes: - Added ToTemplateData() method to TemplatableJob that converts the struct to a map with lowercase keys using JSON marshaling - Updated ArgoCD dispatcher to use ToTemplateData() for template execution - Updated TerraformCloud dispatcher to use ToTemplateData() for template execution - Updated all tests to use lowercase template variables (e.g., {{.resource.name}} instead of {{.Resource.Name}}) This ensures consistency with verification templating which already uses lowercase variables (e.g., {{.release.version.tag}}). Template variable naming now follows JSON tag conventions: - {{.resource.name}} - resource name - {{.environment.name}} - environment name - {{.release.version.tag}} - release version tag - {{.release.variables.KEY}} - release variables - {{.job.id}} - job ID - {{.deployment.name}} - deployment name Closes #738 Co-authored-by: justin <justin@wandb.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize Go templating variable casing to lowercase to ensure consistency across all templating surfaces.
Previously,
ProviderContextused JSON marshaling, resulting in lowercase template keys, whileTemplatableJobwas passed directly, exposing PascalCase Go struct field names. This PR introduces aMap()method forTemplatableJobto convert its fields to a map with lowercase keys (matching JSON tags), aligning all templating surfaces with a consistent lowercase naming convention as requested in #738.