Fix image tag name for devel#16
Open
cigamit wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the development image publishing workflow to use a GHCR-compatible Docker tag format (avoiding + in the tag), aligning the generated image reference with registries that enforce Docker tag character constraints.
Changes:
- Replace
+git<sha>with_git<sha>in the generated version/tag string used for devel image builds. - Update the computed
IMGreference used bymake docker-buildxwhen pushing devel images.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --build-arg OPERATOR_VERSION=${{ steps.date.outputs.year }}.${{ steps.date.outputs.month }}.${{ steps.date.outputs.day }}+git${{ steps.short-sha.outputs.sha }}" \ | ||
| IMG=ghcr.io/${{ github.repository }}_devel:${{ steps.date.outputs.year }}.${{ steps.date.outputs.month }}.${{ steps.date.outputs.day }}+git${{ steps.short-sha.outputs.sha }} \ | ||
| --build-arg OPERATOR_VERSION=${{ steps.date.outputs.year }}.${{ steps.date.outputs.month }}.${{ steps.date.outputs.day }}_git${{ steps.short-sha.outputs.sha }}" \ | ||
| IMG=ghcr.io/${{ github.repository }}-devel:${{ steps.date.outputs.year }}.${{ steps.date.outputs.month }}.${{ steps.date.outputs.day }}_git${{ steps.short-sha.outputs.sha }} \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github doesn't like + in the tag name, even though it does over on Ascender.