Add delete icon on hover for partner orgs in program form dropdown#166
Open
alexy-ok wants to merge 4 commits into
Open
Add delete icon on hover for partner orgs in program form dropdown#166alexy-ok wants to merge 4 commits into
alexy-ok wants to merge 4 commits into
Conversation
Shows a per-row delete icon button in the partner organization search dropdown; clicking it opens a confirmation modal that permanently removes the organization via DELETE /partners/:id. Clears the selection if the deleted org was currently chosen. Adds partnerOrg i18n keys for all four locales.
Contributor
There was a problem hiding this comment.
2 issues found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="client/src/components/dashboard/ProgramForm/StudentsInstrumentsSection.jsx">
<violation number="1" location="client/src/components/dashboard/ProgramForm/StudentsInstrumentsSection.jsx:196">
P2: Clear `selectedInstrument` when deleting that instrument; otherwise the picker can keep a stale id and subsequent Add attempts fail silently.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows a per-row delete icon button in the partner organization search dropdown; clicking it opens a confirmation modal that permanently removes the organization via DELETE /partners/:id. Clears the selection if the deleted org was currently chosen. Adds partnerOrg i18n keys for all four locales.
Description
Screenshots/Media
Issues
Closes #
Summary by cubic
Add a per-row delete action to partner organization and instrument dropdowns in the program form. Users confirm in a modal; on delete we remove the item and clear the current selection or instrument entry.
SearchInputdropdown rows./partners/:id, remove from list; clear selection if chosen./instruments/:id, remove from list and form data; show an error toast on failure.partnerOrg(en/es/fr/zh) andinstruments(en/es/fr).Written for commit 244ab11. Summary will update on new commits. Review in cubic