Skip to content

Add delete icon on hover for partner orgs in program form dropdown#166

Open
alexy-ok wants to merge 4 commits into
mainfrom
cursor/partner-org-delete-from-dropdown
Open

Add delete icon on hover for partner orgs in program form dropdown#166
alexy-ok wants to merge 4 commits into
mainfrom
cursor/partner-org-delete-from-dropdown

Conversation

@alexy-ok
Copy link
Copy Markdown
Member

@alexy-ok alexy-ok commented May 22, 2026

Shows a per-row delete icon button in the partner organization search dropdown; clicking it opens a confirmation modal that permanently removes the organization via DELETE /partners/:id. Clears the selection if the deleted org was currently chosen. Adds partnerOrg i18n keys for all four locales.

Description

Screenshots/Media

Issues

Closes #


Summary by cubic

Add a per-row delete action to partner organization and instrument dropdowns in the program form. Users confirm in a modal; on delete we remove the item and clear the current selection or instrument entry.

  • New Features
    • Hover-only delete icon in SearchInput dropdown rows.
    • Partner orgs: confirm, DELETE /partners/:id, remove from list; clear selection if chosen.
    • Instruments: confirm, DELETE /instruments/:id, remove from list and form data; show an error toast on failure.
    • i18n: add delete strings for partnerOrg (en/es/fr/zh) and instruments (en/es/fr).

Written for commit 244ab11. Summary will update on new commits. Review in cubic

Shows a per-row delete icon button in the partner organization search dropdown; clicking it opens a confirmation modal that permanently removes the organization via DELETE /partners/:id. Clears the selection if the deleted org was currently chosen. Adds partnerOrg i18n keys for all four locales.
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="client/src/components/dashboard/ProgramForm/StudentsInstrumentsSection.jsx">

<violation number="1" location="client/src/components/dashboard/ProgramForm/StudentsInstrumentsSection.jsx:196">
P2: Clear `selectedInstrument` when deleting that instrument; otherwise the picker can keep a stale id and subsequent Add attempts fail silently.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread client/public/locales/fr/translation.json Outdated
alexy-ok and others added 2 commits May 22, 2026 16:21
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant