Remove the hardcoded URL added in df672d2 #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ubuntu-latest` can't install python 3.7 anymore, resulting in this workflow error: ``` Version 3.7 was not found in the local cache Error: Version 3.7 with arch x64 not found The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json ``` Pinning to the latest ubuntu version that has 3.7 to avoid this.
This was added in 27d364e, and it's making tests fail: ``` Run mypy ibflex tests ... ibflex/Types.py:471: error: Name "currency" already defined on line 386 [no-redef] ```
make tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the hardcoded URL added in df672d2.
Fly-by change: fix commit workflow failures.