Skip to content

Frontend/Purchase copy update#1560

Merged
isabeleliassen merged 1 commit into
csg-org:mainfrom
InspiringApps:frontend/purchase-expiry-copy-update
May 15, 2026
Merged

Frontend/Purchase copy update#1560
isabeleliassen merged 1 commit into
csg-org:mainfrom
InspiringApps:frontend/purchase-expiry-copy-update

Conversation

@jsandoval81
Copy link
Copy Markdown
Collaborator

@jsandoval81 jsandoval81 commented May 14, 2026

Requirements List

  • None

Description List

  • Update expiration text on privilege purchase Payment Summary screen

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review
  • Testing
    • First checkbox on Payment Summary screen should now read: If purchased, these privileges will expire on [DATE].

Closes #1492

Summary by CodeRabbit

  • Documentation
    • Simplified the license expiration message in English and Spanish translations for improved clarity.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

📝 Walkthrough

Walkthrough

This PR updates the purchase privilege expiration message text in English and Spanish localization files. Both translations were simplified to remove references to the home state license and now only state the expiration date.

Changes

Localization Updates

Layer / File(s) Summary
Purchase Expiration Message Localization
webroot/src/locales/en.json, webroot/src/locales/es.json
The purchaseExpirationMessage string was updated in English (line 637) to remove the "same as the home state license" clause, and in Spanish (line 614) to remove the non-breaking space and simplify the message to only reference the {date} expiration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • csg-org/CompactConnect#1460: Updates to the purchase-expiry UI flow that consumes the purchaseExpirationMessage localization strings being modified in this PR.

Suggested reviewers

  • jlkravitz
  • isabeleliassen
  • rmolinares

Poem

🐰 A rabbit hops through translation land,
Simplifying dates with a swift hand,
License clauses fade away,
Clearer messages shine today! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Frontend/Purchase copy update' is related to the changeset which updates localization strings for a purchase expiration message, but is vague and doesn't clearly indicate the specific change. Consider a more specific title such as 'Update purchase expiration message copy in en and es locales' to better convey the actual changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR changes directly address the objective from issue #1492: removing the phrase 'the same as the home state license' from the expiration message in both English and Spanish locales.
Out of Scope Changes check ✅ Passed All changes are scoped to updating localization strings for the purchase expiration message in the specified locales, directly aligned with issue #1492 requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description includes all required sections: Requirements List, Description List, and Testing List with comprehensive details.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jsandoval81 jsandoval81 requested a review from jlkravitz May 14, 2026 16:23
@jsandoval81
Copy link
Copy Markdown
Collaborator Author

@jlkravitz This is ready for your review.

Copy link
Copy Markdown
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge.

@isabeleliassen isabeleliassen merged commit 6136afb into csg-org:main May 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adjust privilege expiration date language

3 participants