Frontend/discipline table#1549
Open
jsandoval81 wants to merge 2 commits into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR adds a discipline section to the LicensingDetail page that displays licensee adverse actions. It introduces a new AlertCircle icon component, extends the Licensee and AdverseAction data models, adds localization strings, and implements responsive UI with collapsible discipline records including sorting by start date and state. ChangesDiscipline and Adverse Action UI and Data
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
webroot/src/pages/LicensingDetail/LicensingDetail.less (1)
299-378: 💤 Low value
.no-disciplineelement has no style rule defined.The Vue template renders
<div class="no-discipline">when there are no discipline records, but no corresponding CSS rule exists for it. The text will display with no indentation, padding, or font styling — inconsistent with other "empty state" presentations on the page.🎨 Suggested fix
.discipline-list { ... } + + .no-discipline { + padding: 1.6rem 0; + color: `@fontColorLight`; + } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@webroot/src/pages/LicensingDetail/LicensingDetail.less` around lines 299 - 378, Add a CSS rule for the .no-discipline element in LicensingDetail.less (place it near .discipline-section/.discipline-list for discoverability) so the empty-state matches other rows: give .no-discipline similar margin/padding and top-border as .discipline-row (padding: 1.6rem 0; border-top when not-first or explicit top border), set font-weight or muted color consistent with .cell-title/.header, and ensure responsive behavior (tablet/desktop media queries) so it aligns with other .discipline-cell layout; target the class name ".no-discipline" to implement these styles.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webroot/src/pages/LicensingDetail/LicensingDetail.ts`:
- Around line 348-360: The comparator sortByDisciplineStart currently compares
display-formatted dates from AdverseAction.startDateDisplay(), which are
M/D/YYYY strings and sort incorrectly; change it to compare the underlying ISO
date values (e.g., AdverseAction.startDate) or parse the ISO strings into Date
objects and compare numerically so ordering is correct; update
sortByDisciplineStart to read action1.startDate and action2.startDate (or
Date.parse(action1.startDate)/Date.parse(action2.startDate)) and return -1/0/1
based on those comparisons.
---
Nitpick comments:
In `@webroot/src/pages/LicensingDetail/LicensingDetail.less`:
- Around line 299-378: Add a CSS rule for the .no-discipline element in
LicensingDetail.less (place it near .discipline-section/.discipline-list for
discoverability) so the empty-state matches other rows: give .no-discipline
similar margin/padding and top-border as .discipline-row (padding: 1.6rem 0;
border-top when not-first or explicit top border), set font-weight or muted
color consistent with .cell-title/.header, and ensure responsive behavior
(tablet/desktop media queries) so it aligns with other .discipline-cell layout;
target the class name ".no-discipline" to implement these styles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6ac74b7b-4607-4a72-86d5-502d050c4be2
📒 Files selected for processing (15)
webroot/src/components/Icons/AlertCircle/AlertCircle.lesswebroot/src/components/Icons/AlertCircle/AlertCircle.spec.tswebroot/src/components/Icons/AlertCircle/AlertCircle.tswebroot/src/components/Icons/AlertCircle/AlertCircle.vuewebroot/src/locales/en.jsonwebroot/src/locales/es.jsonwebroot/src/models/AdverseAction/AdverseAction.model.spec.tswebroot/src/models/AdverseAction/AdverseAction.model.tswebroot/src/models/Licensee/Licensee.model.spec.tswebroot/src/models/Licensee/Licensee.model.tswebroot/src/models/StaffUser/StaffUser.model.spec.tswebroot/src/network/mocks/mock.data.tswebroot/src/pages/LicensingDetail/LicensingDetail.lesswebroot/src/pages/LicensingDetail/LicensingDetail.tswebroot/src/pages/LicensingDetail/LicensingDetail.vue
rmolinares
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements List
Description List
adverseActionstop-level propertyTesting List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #1477
Summary by CodeRabbit
New Features
Style
Tests