RequestShare: Introduce the notion of a share request#194
Open
mickenordin wants to merge 2 commits intodevelopfrom
Open
RequestShare: Introduce the notion of a share request#194mickenordin wants to merge 2 commits intodevelopfrom
mickenordin wants to merge 2 commits intodevelopfrom
Conversation
| Consumer specific identifier of the user, group or federation that | ||
| wants to recive a share of the resource. | ||
| example: 51dc30ddc473d43a6011e9ebba6ca770@geant.org | ||
| shareId: |
Contributor
There was a problem hiding this comment.
Is this the same as providerId in NewShare ?
glpatcern
requested changes
Aug 22, 2025
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
I went for a review of this new flow, hope I have understood the rationale, and of course all open for further comments.
| Consumer specific identifier of the user, group or federation that | ||
| wants to recive a share of the resource. | ||
| Example: "51dc30ddc473d43a6011e9ebba6ca770@geant.org" | ||
| * REQUIRED shareId (string) |
Member
There was a problem hiding this comment.
Here we have a problem: a receiver won't know the (opaque) ID of a remote resource, but only a path (or something "human readable"?). Shall we name this simply share, or sharePath?
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
mickenordin
force-pushed
the
kano-request
branch
from
1fb6942 to
2169dc9
Compare
glpatcern
reviewed
Apr 7, 2026
Comment on lines
+58
to
+59
| description: > | ||
| Bad request due to invalid parameters, e.g. when `shareId` is missing. |
Member
There was a problem hiding this comment.
If the share identifier/path is missing or not found, a 404 would be more appropriate here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.