Skip to content

Conversation

@wysiwys
Copy link
Collaborator

@wysiwys wysiwys commented May 5, 2025

This draft pull request updates the formats accepted by this action, in order to allow for more flexibility and provide more granular control over the keys in each benchmark.

  • Allow unit to include 'μ' character in cargo input
  • Allow range to be missing in cargo input
  • Accept key-value pairs as a list of (key=value) items

It also updates tests and test data to take these changes into account, and additionally updates all of the examples and tests to output to a file with the .json extension rather than one with the the .txt extension.

@wysiwys wysiwys self-assigned this May 5, 2025
@wysiwys wysiwys marked this pull request as ready for review May 5, 2025 06:58
@wysiwys wysiwys requested a review from keks May 5, 2025 08:46
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@wysiwys wysiwys merged commit 36a40d6 into main May 5, 2025
5 checks passed
@wysiwys wysiwys deleted the wysiwys/more-flexible-input branch May 5, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants