Blackcoin staking pool fix #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Multi-deposits in single Txid
Add Beyondcoin to the list of projects using the bot.
Update projects using the bot
Add an option to allow the bot to respond in any server
Added Shroud Protocol
Added / replaced / changed parts of code for Bot to be able to handle BlackCoin and it's forks staking pool. WARNING: these changes probably broke original code functions!!! Do not use on any other coins without prior testing!!!
Added / replaced / changed parts of code for Bot to be able to handle BlackCoin and it's forks staking pool. WARNING: these changes probably broke original code functions!!! Do not use on any other coins without prior testing!!!
Code adjustment for the calculations of stake amount (mint) received and to be distributed between pool participants. WARNING: Now code does not take into account if a non-DB wallet addresses receives a stake reward! ALL STAKE REWARDS of the BOT wallet are counted as a POOL REWARD! Also also part of added code excludes a Bogus (Reorg'ed) Tx's (met at DiminutiveVaultCoin (DIMI)) gets pushed into database as a "stake" by the original code but has no value and non-existent on the chain after Reorg.
Added info about this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a look at the changes. These additions/changes were made to accommodate a BlackCoin/NovaCoin forks like: DiminutiveVaultCoin (DIMI) - this one has a Bogus Tx's which get Reorg'ed and dropped out from the chain but where getting marked as "stake" after inclusion into DB.
InfiniLooP (IL8P).
Stake amount to the users was giving inconsistent amounts even if all staked coins belong to the pool wallet. For example - stake reward is 0.01, but the calculated value could have been between the (0.01 - "bot owner %") to a more than double of that (0.0243....) So calculation was changed as well here.
And a rpc call with gettransaction in these coins has no minted "amount" in the reply, so that has to be pulled from rpcgetblock .
All the changes done here probably break functionality on other coins, but may be these can be added with some modifications to your original code?