Skip to content

Conversation

@cryptaliagy
Copy link
Owner

Closes #18

This feature allows a user to specify the endpoint to be used by setting the HTTPGET_ENDPOINT environment variable. It is assumed that an invocation with no arguments will use the environment variable, and an invocation with an argument will use the argument as the endpoint.

@cryptaliagy cryptaliagy requested a review from Copilot January 14, 2025 21:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@cryptaliagy cryptaliagy requested a review from Copilot January 14, 2025 22:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cryptaliagy cryptaliagy requested a review from Copilot January 14, 2025 22:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/main.rs:18

  • The new behavior of using the HTTPGET_ENDPOINT environment variable should be covered by tests.
env::var("HTTPGET_ENDPOINT").expect("Environment variable HTTPGET_ENDPOINT not set")

@cryptaliagy cryptaliagy merged commit 14e241a into main Jan 14, 2025
2 checks passed
@cryptaliagy cryptaliagy deleted the nmaximo/readFromEnvironment branch January 14, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read URL from an environment variable

2 participants