Conversation
|
@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@buixor: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4445 +/- ##
==========================================
+ Coverage 63.74% 63.79% +0.04%
==========================================
Files 476 476
Lines 33902 33926 +24
==========================================
+ Hits 21611 21643 +32
+ Misses 10145 10137 -8
Partials 2146 2146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/kind enhancement |
There was a problem hiding this comment.
Pull request overview
This PR adds wildcard expansion support for appsec_config and appsec_configs acquisition module settings, allowing users to reference multiple installed hub appsec-configs via * / ? patterns while preserving the previous behavior for literal (non-glob) entries.
Changes:
- Added
resolveAppsecConfigEntry()to expand glob-like config entries into installed hubappsec-configsitem names. - Updated
Source.Configure()to resolve and load all matched appsec-config names for bothappsec_configandappsec_configs. - Added unit tests covering literal passthrough, wildcard expansion,
?matching, no-match errors, and skipping uninstalled items.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/acquisition/modules/appsec/config.go | Adds wildcard resolution logic and uses it to load one-or-many hub appsec-configs during source configuration. |
| pkg/acquisition/modules/appsec/config_test.go | Introduces focused unit tests for wildcard resolution against a minimal in-memory hub fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.