Skip to content

support wildcards in appsec-config(s)#4445

Open
buixor wants to merge 3 commits intomasterfrom
appsec-configs-wildcard
Open

support wildcards in appsec-config(s)#4445
buixor wants to merge 3 commits intomasterfrom
appsec-configs-wildcard

Conversation

@buixor
Copy link
Copy Markdown
Contributor

@buixor buixor commented Apr 28, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link
Copy Markdown

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.79%. Comparing base (847fe3e) to head (688fe1c).

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/config.go 48.27% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4445      +/-   ##
==========================================
+ Coverage   63.74%   63.79%   +0.04%     
==========================================
  Files         476      476              
  Lines       33902    33926      +24     
==========================================
+ Hits        21611    21643      +32     
+ Misses      10145    10137       -8     
  Partials     2146     2146              
Flag Coverage Δ
bats 46.87% <17.24%> (-0.02%) ⬇️
unit-linux 36.94% <41.37%> (+0.04%) ⬆️
unit-windows 25.62% <41.37%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buixor buixor marked this pull request as ready for review May 4, 2026 08:02
Copilot AI review requested due to automatic review settings May 4, 2026 08:02
@buixor
Copy link
Copy Markdown
Contributor Author

buixor commented May 4, 2026

/kind enhancement
/area appsec

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds wildcard expansion support for appsec_config and appsec_configs acquisition module settings, allowing users to reference multiple installed hub appsec-configs via * / ? patterns while preserving the previous behavior for literal (non-glob) entries.

Changes:

  • Added resolveAppsecConfigEntry() to expand glob-like config entries into installed hub appsec-configs item names.
  • Updated Source.Configure() to resolve and load all matched appsec-config names for both appsec_config and appsec_configs.
  • Added unit tests covering literal passthrough, wildcard expansion, ? matching, no-match errors, and skipping uninstalled items.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/acquisition/modules/appsec/config.go Adds wildcard resolution logic and uses it to load one-or-many hub appsec-configs during source configuration.
pkg/acquisition/modules/appsec/config_test.go Introduces focused unit tests for wildcard resolution against a minimal in-memory hub fixture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/appsec kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants