Migrate file acquisition + New tail_mode and stat_poll_interval settings to support not keeping file handles permanently open#4280
Conversation
# Conflicts: # pkg/acquisition/modules/file/run.go
|
@david-garcia-garcia: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@david-garcia-garcia: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4280 +/- ##
==========================================
+ Coverage 63.02% 63.11% +0.08%
==========================================
Files 473 474 +1
Lines 33498 33741 +243
==========================================
+ Hits 21112 21295 +183
- Misses 10273 10321 +48
- Partials 2113 2125 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/kind refactoring |
This is a POC of migrating tail to use context.
Unfortunately the underlying library used does not support context, so I just removed it.