-
Notifications
You must be signed in to change notification settings - Fork 556
Update maxmind reader to v2 #4112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…om return type for geoip helpers
|
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
/kind chore |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4112 +/- ##
==========================================
- Coverage 62.96% 62.84% -0.12%
==========================================
Files 464 464
Lines 33286 33288 +2
==========================================
- Hits 20957 20920 -37
- Misses 10212 10243 +31
- Partials 2117 2125 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update
maxminddb-golangto v2.The v2 of
geoip2-golanghas changed the name of some fields (IsoCode->ISOCode), which would break any expression trying to access theIsoCodefield of the value returned byGeoIPEnrich().As such, drop usage of
geoip2-golang, as it was just a thin wrapper on top of the reader, and use a custom struct to have better control of the struct fields.This also allows us to create one less reader, we had 3 before:
GeoIPRangeEnrichhelperGeoIPEnrichGeoIPASNEnrichWith this change, we now only have 2 lower-level readers, one per database loaded.
Note: hub test failures need to be fixed in the hub before we merge.