Skip to content

fix(docs): compile the bqRE once at package level #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tampakrap wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(docs): compile the bqRE once at package level #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/crossplane/docs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ import (
//go:embed docs-templates/command-reference.md.tmpl
var docsTmpl string

// bqRE matches the opening of a special blockquote: > **Word:** text.
var bqRE = regexp.MustCompile(`^> \*\*(\w+):\*\* `)

type docsCmd struct {
OutputFile string `default:"command-reference.md" help:"Path to write the generated command-reference markdown file." name:"output-file" short:"o" type:"path"`

Expand Down Expand Up @@ -203,7 +206,6 @@ func normalizeDetail(detail string, headingLevel int) string {
}

// Convert special blockquotes into pretty Hugo blocks.
bqRE := regexp.MustCompile(`^> \*\*(\w+):\*\* `)
bqMatch := bqRE.FindStringSubmatch(line)
if bqMatch != nil {
// Omit the feature enablement message from the top-level command
Expand Down
Loading