Feature: use proxy-url from cluster in kubeconfig if set #387
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Schütz <fabian.f.schuetz@mercedes-benz.com>
veith4f
requested review from
lsviben,
morningspace,
phisco,
sergenyalcin,
turkenf and
turkenh
as code owners
Author
|
Was now successfully deployed, packaged, installed and tested in our environment. Kubernetes Object was correctly provisioned. |
|
Compiled, packaged, deployed, installed, and tested provider-kubernetes and provider-helm based on this branch. Everything works as expected with proxy-url in private EKS cluster and without proxy-url in public EKS cluster. Thanks @veith4f for this work. Can we get this contribution merged? See #347. |
turkenf
reviewed
Oct 29, 2025
| // See https://pkg.go.dev/k8s.io/client-go/rest#Config | ||
| if cluster.ProxyURL != "" { | ||
| return func(*http.Request) (*url.URL, error) { | ||
| return url.Parse(cluster.ProxyURL) |
Collaborator
There was a problem hiding this comment.
It would be good to add explicit error handling for the url.Parse() call to catch invalid proxy URLs.
Suggested change
| return url.Parse(cluster.ProxyURL) | |
| parsedURL, err := url.Parse(cluster.ProxyURL) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return parsedURL, nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Clusters in kubeconfig may have a field
proxy-urlthat needs to be respected to reach the specified endpoints.Currently,
client.goin the provider does not respect this.struct rest.Configcreated inclient.gooffers a fieldproxy:func(*http.Request) (*url.URL, error)that may be used to this end.How has this code been tested
Just compile/deploy-local as of now. Want to see if there is interest.