feat!: ability to select namespace from composite field path#83
Closed
tenstad wants to merge 5 commits intocrossplane-contrib:mainfrom
Closed
feat!: ability to select namespace from composite field path#83tenstad wants to merge 5 commits intocrossplane-contrib:mainfrom
tenstad wants to merge 5 commits intocrossplane-contrib:mainfrom
Conversation
…SelectorLabelMatcher Signed-off-by: Amund Tenstad <github@amund.io>
Signed-off-by: Amund Tenstad <github@amund.io>
…t policy Signed-off-by: Amund Tenstad <github@amund.io>
Signed-off-by: Amund Tenstad <github@amund.io>
Signed-off-by: Amund Tenstad <github@amund.io>
22b229e to
f4e42c5
Compare
Author
|
Closing as breaking changes are not desired. Could recreate under a different key if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related to https://crossplane.slack.com/archives/C08BBMDCH7W/p1769948003900819
Reworks the current
namespace: stringto configure either aValueor to be an extracted valueFromCompositeFieldPath.The selector struct for
namespacereuses the selector used for labels values today, making it easy to extend both to e.g. supportFromEnvironmentFieldPathin the future.Could do the same non-breakingly by adding a new
namespaceFromfield instead of modifying the existingnamespace.See commit log for step by step implementation process.
Fixes #61
I have: