Add consistent type imports rule #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Member
Author
|
Suggested and approved on Slack |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the @typescript-eslint/consistent-type-imports ESLint rule to enforce consistent use of type imports across the TypeScript codebase. The rule is documented in the linked TypeScript ESLint blog post and helps distinguish between value imports and type-only imports.
Changes:
- Enabled the
@typescript-eslint/consistent-type-importsrule as an error in the TypeScript configuration - Updated two rule files to use
import typesyntax for type-only imports (RuleFix and TSESTree)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/configs/typescript.ts | Added @typescript-eslint/consistent-type-imports rule configuration set to 'error' |
| src/rules/parameter-destructuring/index.ts | Changed RuleFix import to use import type syntax |
| src/rules/min-chained-call-depth/index.ts | Split imports to separate type imports (TSESTree) from value imports (AST_TOKEN_TYPES, AST_NODE_TYPES) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable consistent type import rule. See https://typescript-eslint.io/blog/consistent-type-imports-and-exports-why-and-how/