Skip to content

Conversation

@renan628
Copy link
Member

@renan628 renan628 commented Aug 19, 2025

Summary

This PR defers the Default while miss cache loader execution to ensure the default value is returned before the surrounding cache executes, avoiding a potential race condition.

Related to:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@renan628 renan628 self-assigned this Aug 19, 2025
@renan628 renan628 requested review from a team as code owners August 19, 2025 21:27
@renan628 renan628 added the enhancement Improvement of existing features label Aug 19, 2025
@github-actions
Copy link

👋 @renan628

Thanks for your contribution!

The approval and merge process is almost fully automated 🧙

Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.

Happy coding! 🎉

@Fryuni Fryuni merged commit ab3d4d5 into master Aug 19, 2025
8 checks passed
@Fryuni Fryuni deleted the defer-default-while-miss-loader branch August 19, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defer default while miss cache loader

4 participants