-
-
Notifications
You must be signed in to change notification settings - Fork 359
Add Azure OpenAI provider, take 2 #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@gjtorikian, thank you for doing this. 🙏 |
|
@crmne bump for review on this? I’m not keen to keep fixing merge conflicts if there’s no interest. context: MSFT gives out 100k in free OpenAI credits to qualifying startups so I suspect there are a lot of people using their Azure tie-in (myself included) that would benefit from an official way to integrate, rather than monkey patching. |
Thanks for your work on this, hope will be merged soon |
What this does
This is a continuation of @oxaroky02's excellent PR (#279); in fact, I cherry-picked most of their commits. As mentioned, this adds the Azure OpenAI provider:
A lot of changes occurred since the PR was first opened, and, as I didn't have access to make changes to the original branch, I decided to just open a new PR with the fixes necessary to speed things up and push this addition over the line. Those changes include:
moduleto aclassThe biggest "gotcha" is that Azure OpenAI does not have all the models that "regular" OpenAI has; as well, the endpoints for some of the features are different. So there's some inheritance from the OpenAI provider going on, and some patches necessary to get this working with Azure.
Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)API changes
Related issues
Closes #15