Skip to content

Remove async void Dispose() anti-pattern from KvExplorerDb #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Remove async void Dispose() anti-pattern from KvExplorerDb #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cdfb40
Initial plan
Copilot Nov 15, 2025
1cebbcc
Remove async void Dispose() and IDisposable interface
Copilot Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions KeyVaultExplorer/Database/KvExplorerDb.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,14 @@

namespace KeyVaultExplorer.Database;

public partial class KvExplorerDb : IDisposable
public partial class KvExplorerDb
{
private static string _password = null;

public KvExplorerDb()
{
}

public async void Dispose()
{
using var connection = await TryCreateDatabaseAndOpenConnection();
await connection.CloseAsync();
}

public async Task<bool> DeleteQuickAccessItemByKeyVaultId(string keyVaultId)
{
using var connection = await TryCreateDatabaseAndOpenConnection();
Expand Down
2 changes: 1 addition & 1 deletion KeyVaultExplorer/ViewModels/KeyVaultTreeListViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public KeyVaultTreeListViewModel()
{
_authService = Defaults.Locator.GetRequiredService<AuthService>();
_vaultService = Defaults.Locator.GetRequiredService<VaultService>();
using var _ = _dbContext = Defaults.Locator.GetRequiredService<KvExplorerDb>();
_dbContext = Defaults.Locator.GetRequiredService<KvExplorerDb>();
_notificationViewModel = Defaults.Locator.GetRequiredService<NotificationViewModel>();
_clipboardService = Defaults.Locator.GetRequiredService<ClipboardService>();
// PropertyChanged += OnMyViewModelPropertyChanged;
Expand Down