fix(cache): rename input parameter to tool_input to avoid shadowing builtin#5741
Open
Immanuel2004 wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix(cache): rename input parameter to tool_input to avoid shadowing builtin#5741Immanuel2004 wants to merge 1 commit intocrewAIInc:mainfrom
Immanuel2004 wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
…uiltin - Rename 'input' parameter to 'tool_input' in CacheHandler.add() and CacheHandler.read() - Update all call sites in lib/crewai/src/crewai/project/utils.py - Remove TODO comments about parameter shadowing - Improves code clarity and follows Python naming conventions All existing tests pass without modification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the parameter shadowing issue in CacheHandler by renaming the
inputparameter totool_inputin bothadd()andread()methods.Changes
input→tool_inputin CacheHandlerlib/crewai/src/crewai/project/utils.pyTesting
test_disabling_cache_for_agentpassedtest_cache_hitting_between_agentspassed