PackageBuilder: honour OBJCOPY env and use llvm-strip under ZigToolchain#1171
Closed
henderkes wants to merge 1 commit into
Closed
PackageBuilder: honour OBJCOPY env and use llvm-strip under ZigToolchain#1171henderkes wants to merge 1 commit into
henderkes wants to merge 1 commit into
Conversation
extractDebugInfo() now picks up OBJCOPY from the environment (falling back to plain `objcopy`), so cross builds that ship their own objcopy (e.g. llvm-objcopy via zig) don't have to inject it into PATH or shim the binary name. stripBinary() asks ApplicationContext for the active toolchain and, when it's ZigToolchain, runs the llvm-strip shipped under PKG_ROOT_PATH/llvm-tools/bin instead of the system strip — system strip doesn't understand zig-produced archives and bitcode sections. Other toolchains keep using plain `strip`. ApplicationContext::tryGet() wraps get() in a try/catch and returns null on failure, so callers can ask "is this resolvable right now" without PHP-DI's has() lying about autowirable-but-unconstructable classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractDebugInfo() now picks up OBJCOPY from the environment (falling back to plain
objcopy), so cross builds that ship their own objcopy (e.g. llvm-objcopy via zig) don't have to inject it into PATH or shim the binary name.stripBinary() asks ApplicationContext for the active toolchain and, when it's ZigToolchain, runs the llvm-strip shipped under PKG_ROOT_PATH/llvm-tools/bin instead of the system strip — system strip doesn't understand zig-produced archives and bitcode sections. Other toolchains keep using plain
strip.ApplicationContext::tryGet() wraps get() in a try/catch and returns null on failure, so callers can ask "is this resolvable right now" without PHP-DI's has() lying about autowirable-but-unconstructable classes.
What does this PR do?
Checklist before merging
*.phpor*.yml, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:lint-config