Feat/pgo v3 by henderkes · Pull Request #1138 · crazywhalecc/static-php-cli

henderkes · 2026-05-11T07:34:25Z

What does this PR do?

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

If you modified *.php or *.json, run them locally to ensure your changes are valid:
- composer cs-fix
- composer analyse
- composer test
- bin/spc dev:sort-config
If it's an extension or dependency update, please ensure the following:
- Add your test combination to src/globals/test-extensions.php.
- If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

…ywhere

github-actions · 2026-05-12T00:52:59Z

StaticPHP Test Bot

Detected: Extensions: fastchart, fastjson | Libraries: bzip2, fastlz, icu, imagemagick, jbig, krb5, libaom, libheif, liblz4, ncurses, openssl, postgresql, qdbm, unixodbc, watcher | Targets: llvm-compiler-rt, llvm-tools, php
Active labels: none
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS

henderkes · 2026-05-12T01:24:38Z

(I tested with static-php/packages v3 branch, php 8.5 zig on rpm. Tests with Alpine and gcc are still to finish in a few hours when ci runs.)

henderkes · 2026-05-12T01:26:00Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

crazywhalecc · 2026-05-12T01:50:27Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

…ith different pkg_root_path set

…fined behaviour sanitizer)

henderkes · 2026-05-12T04:27:00Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

Okay, added curl.exe on Windows too. Also figured out the root cause of the BUILD_CC patch minilua crash (zigs undefined behaviour sanitizer tripping up, if you run CC="clang -fsanitize=undefined" it will also fail) which coincidentally also fixed a possible edge case bug. BUILD_CC is also used for gen_ir so by using a different vm type it could have theoretically clashed.

henderkes · 2026-05-12T05:59:38Z

Oh, there's even an issue running the binaries despite no undefined sanitizer that I can't reproduce locally or in docker. Very weird.

henderkes · 2026-05-19T16:06:27Z

It's working as intended now, but compiling llvm binutils is really taking quite some time. We should host a prebuilt package for that and use that regardless of whether the user prefers prebuilts or not, there's no reason to rebuild this. It's static (always compiled with -musl) per arch-os.

I tried downloading llvm tarball instead, but GitHub gives me such a bad connection here in SEA that the wait time is too ridiculous.

crazywhalecc · 2026-05-20T09:14:18Z

We should host a prebuilt package for that and use that regardless of whether the user prefers prebuilts or not

Just add a workflow in static-php/hosted repo like icu-static-windows one.

crazywhalecc · 2026-05-20T09:15:18Z

I tried downloading llvm tarball instead, but GitHub gives me such a bad connection here in SEA that the wait time is too ridiculous.

😞 Singapore VPN has the best speed accessing GitHub for me.

crazywhalecc · 2026-05-22T02:34:22Z

+<?php
+
+declare(strict_types=1);
+
+namespace StaticPHP\Doctor\Item;
+
+use StaticPHP\Attribute\Doctor\CheckItem;
+use StaticPHP\Attribute\Doctor\FixItem;
+use StaticPHP\Attribute\Doctor\OptionalCheck;
+use StaticPHP\DI\ApplicationContext;
+use StaticPHP\Doctor\CheckResult;
+use StaticPHP\Package\PackageInstaller;
+
+#[OptionalCheck([self::class, 'optionalCheck'])]
+class GoXcaddyCheck


Is there any reason that we must check go-xcaddy in doctor check?

not strictly necessary, but it makes things like pre building images by just running doctor a bit easier. you can remove it if you want

Oh, I did forget to consider the base image in v3. But for FrankenPHP, I think it's easy to just run bin/spc install-pkg go-xcaddy after the doctor command.

crazywhalecc · 2026-05-22T02:36:12Z

     */
    public function stripBinary(string $binary_path): void
    {
+        $strip = ApplicationContext::tryGet(ToolchainInterface::class) instanceof ZigToolchain


Why tryGet here?

for some reason the DI library you're using returns "true" for ->has even if the class is in fact not autowirable

crazywhalecc · 2026-05-22T02:39:18Z

        return null;
    }

+    private function reconcilePhpSrcVersion(): void


This solution seems too wild, and I don't think it is appropriate here.

crazywhalecc · 2026-05-22T02:42:46Z

+        if ($source_downloaded && $artifact->getName() === 'php-src' && ($requested = $this->getOption('with-php'))) {
+            $info = ApplicationContext::get(ArtifactCache::class)->getSourceInfo('php-src');
+            $cv = $info['version'] ?? null;
+            $ct = $info['cache_type'] ?? null;
+            $matches = $requested === 'git' ? $ct === 'git' : ($cv !== null && $ct !== 'git' && ($cv === $requested || str_starts_with($cv, $requested . '.')));
+            if (!$matches) {
+                $source_downloaded = false;
+            }
+        }
+


you want to try to switch PHP versions simply by changing --with-php?

Yes, --dl-with-php switches the php version in the build command, or spc download --with-php=.. switches the php version too. We shouldn't use the old version in source/php-src when the user explicitly switched it.

Even better would be to have different trees for different php versions (php-src-8.2, ... , php-src-8.5), that would simplify the switch more, but it's a larger refactor.

Edit: v2 already did this with the source dir stale logic. In v3 it kept rebuilding the old php versions even after switching.

Ah, I think I need to look into that. I previously designed a separate command to achieve this bin/spc switch-php-version. I have not considered using --with-php to switch it directly.

Anyway hardcoding looks strange in ArtifactDownloader and PackageInstaller, and I'll take a look at how to fix it later.

Ah, could you also add llvm-tools to static-php/hosted? We only need a x86-64 and an aarch64 version for linux (any maybe macOS in the future, pending m5 mini availability next month). They are linked statically (musl target, like all packages) and only update when zig version updates.

Of course, but let's take them one by one first 🤯 There's so much to do before releasing the first alpha version.

henderkes · 2026-05-22T10:15:35Z

wtf I have no idea what failed in the tests and why. it passes locally and looking for php-config there makes no sense, neither of the new extensions does it

luthermonson · 2026-05-22T16:57:13Z

had claude pull everything and this is what it thinks the problem is with CI

Why it broke now (not a PR regression)

  The earlier runs on this same PR (02:27, 06:11 today) passed. Then it broke at 08:43.

  - 06:11 green run used mongodb-2.3.2.tgz
  - 08:43 failed run used mongodb-2.3.3.tgz
  - mongodb 2.3.3 was released today at 07:07:49Z — right between those two runs
  - spc's ext-mongodb.yml uses type: ghrel + match: mongodb.+\.tgz, which always pulls the latest mongodb release. So CI silently picked up the new
  version.

I'll get a PR up with the fix and we'll see if it's right

mongo-php-driver 2.3.3 added a config.m4 check that falls back to php-config when PHP_VERSION_ID is unset in the shell env. In-tree PHP source builds have no php-config, so configure fails with: checking PHP version... configure: error: php-config not found Set PHP_VERSION_ID from main/php_version.h before configureForUnix so the lookup short-circuits.

… (bleeds libpq polyfills into php configure, poisoning e.g. have_strlcat results)

henderkes · 2026-05-23T13:40:19Z

(current CI failures are because I didn't forward the temporary fixes for fastchart and clickhouse extensions, iliaa will probably release versions with my fixes upstreamed in a few days)

crazywhalecc · 2026-05-23T14:09:37Z

I'd like to merge some easily split parts of this branch into v3 first, so that the branch doesn't become too large and make reviews troublesome.

henderkes · 2026-05-23T14:50:26Z

Yes, I'm getting to a point where building static-php/packages based on this branch is possible. The majority of changes here are really just behaviour fixes that can be applied independently.

henderkes added 5 commits May 10, 2026 19:27

toolchain fixes forward port from v2-pgo

4f76942

better deduplicate_flags

6e32672

update libraries to honour user flags

efdd2a7

use resolved dependency tree instead of asking for with_suggests ever…

743934d

…ywhere

add pgo capabilities v3 style

7e6e9d8

henderkes force-pushed the feat/pgo-v3 branch from 4f57a12 to 7e6e9d8 Compare May 11, 2026 13:55

henderkes added 2 commits May 11, 2026 21:05

Merge remote-tracking branch 'origin/v3' into feat/pgo-v3

bfaa7eb

reset registry

a585359

henderkes marked this pull request as ready for review May 11, 2026 14:49

henderkes requested a review from crazywhalecc May 11, 2026 14:49

crazywhalecc added the need-test This PR has not been tested yet, cannot merge now label May 12, 2026

henderkes added 7 commits May 12, 2026 09:54

use {pkg_root_path} for packages, otherwise containers get confused w…

4172508

…ith different pkg_root_path set

cant reset it because of the same reason x(

270e2d6

trust filesystem, not downloads

c1c34d8

fix BUILD_CC=cc workaround root cause (minijit trips zig default unde…

8453f69

…fined behaviour sanitizer)

fix phpunit failure

57ef042

wrong exception type

defd50f

array

814014e

henderkes force-pushed the feat/pgo-v3 branch from b5d6e3c to 814014e Compare May 12, 2026 04:20

henderkes added 2 commits May 12, 2026 11:22

we don't need this anymore

2415b7d

also build curl exe on windows

4754faf

henderkes added 3 commits May 12, 2026 11:30

don't add fno-sanitize=undefined for library builds

445c0b3

oops

9addbe2

allow * stage to subscribe to everything

b880ef7

fix macOS

433043c

henderkes and others added 2 commits May 20, 2026 16:55

Merge branch 'v3' into feat/pgo-v3

f1525c0

Merge branch 'v3' into feat/pgo-v3

6fe55a4

crazywhalecc reviewed May 22, 2026

View reviewed changes

crazywhalecc and others added 3 commits May 22, 2026 11:23

Update discord invite link

735f126

Add preInstall stage

a23ad55

forward port v2 pgo changes

9d508f1

henderkes added 2 commits May 22, 2026 23:05

address #1155

c40d069

use github tokens for package downloads

d93fdd9

luthermonson and others added 6 commits May 22, 2026 10:03

mongodb: export PHP_VERSION_ID for in-tree builds (#1156)

713f825

backport fixes from v2

e7fb1e2

simplify common zig code paths

1ae989d

dont pass shared extension packages to SPCConfigUtil for building php…

203fed6

… (bleeds libpq polyfills into php configure, poisoning e.g. have_strlcat results)

dont pass all static exts to frankenphp build either

5bdcd3f

cxxflags in spcconfigutil

6ab52a5

henderkes added 4 commits May 24, 2026 12:15

backport v2 passing correct libraries, not all

80d8107

run shared ext builds after frankenphp build

fe4803c

Merge remote-tracking branch 'origin/v3' into feat/pgo-v3

15deecd

revert

f068911

Uh oh!

Conversation

henderkes commented May 11, 2026

What does this PR do?

Checklist before merging

Uh oh!

github-actions Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henderkes commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

crazywhalecc commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

henderkes commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazywhalecc commented May 20, 2026

Uh oh!

crazywhalecc commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henderkes May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henderkes May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henderkes commented May 22, 2026

Uh oh!

luthermonson commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henderkes commented May 23, 2026

Uh oh!

crazywhalecc commented May 23, 2026

Uh oh!

henderkes commented May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 12, 2026 •

edited

Loading

henderkes commented May 19, 2026 •

edited

Loading

crazywhalecc commented May 20, 2026 •

edited

Loading

henderkes May 22, 2026 •

edited

Loading

henderkes May 22, 2026 •

edited

Loading

luthermonson commented May 22, 2026 •

edited

Loading