[6.x] Retire CSRF configuration to legacy GeneralConfig#18806
Open
[6.x] Retire CSRF configuration to legacy GeneralConfig#18806
Conversation
|
Review changes with |
riasvdv
force-pushed
the
feature/retire-csrf-config
branch
from
fd4ee1c to
ce2fdb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Laravel,
PreventRequestForgery(used to be CSRF) is always enabled, the token name is always_tokenandcsrf_token()returns a string whenever the session is set.This is no longer a concern of Craft and we should let the framework deal with it.
Users and plugins can use
PreventRequestForgery::except()in their service providers to exclude urls from the protection.The middleware is only present in the
webmiddleware stack. Registering routes withapiis what's advised for things like webhooks or API routes that don't require CSRF protection. (@AugustMiller might be worth putting in documentation somewhere)