[6.x]: Make system timezone configurable during install#18794
Open
AugustMiller wants to merge 15 commits into6.xfrom
Open
[6.x]: Make system timezone configurable during install#18794AugustMiller wants to merge 15 commits into6.xfrom
AugustMiller wants to merge 15 commits into6.xfrom
Conversation
- The installer may ask for a timezone even when it's present in project config. - Why can I not type `suggest()`’s `info` callback as `string`? The initial "highlighted" value seems to be `null` which upsets it. - The env var detection is pretty crude. We could just parse the value indiscriminately?
|
Review changes with |
# Conflicts: # src/Http/Controllers/Settings/GeneralSettingsController.php
The data wouldn't be included in the initial response, but we were still spending time assembling it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Installmigration now accepts a$timezoneargument.I've made the necessary changes in the CLI installer, but the GUI will need @brianjhanson’s touch!
php artisan craft:installaccepts a--timezoneargumentsuggest()TUI to pick from valid timezone strings (or environment variables that contain one).EnvValueRule, and some surrounding logic was simplified.Questions
timezonewill be used, instead. Room for better UX/DX?suggest()’sinfocallback asstring? The initial "highlighted" value seems to benullwhich upsets it. Docs suggest that it should receive a string…timezonedata I added to the install controller’s Inertia response.I expect this to have at least one collision with #18793, as we both updated some validation rules.