Skip to content

c: changed std::string_view to char* in WAD3.h #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craftablescience merged 2 commits into from
Mar 19, 2026
Merged

c: changed std::string_view to char* in WAD3.h #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
293f55a
c: changed std::string_view to char* in WAD3.h
sheepy676 Mar 19, 2026
191833c
c: changed std::string_view to char* in WAD3.cpp
sheepy676 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lang/c/include/vpkppc/format/WAD3.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

VPKPP_EXTERNVAR const int8_t VPKPP_WAD3_FILENAME_MAX_SIZE;
VPKPP_EXTERNVAR const uint32_t VPKPP_WAD3_SIGNATURE;
VPKPP_EXTERNVAR const std::string_view VPKPP_WAD3_EXTENSION;
VPKPP_EXTERNVAR const char* VPKPP_WAD3_EXTENSION;

VPKPP_API vpkpp_pack_file_handle_t vpkpp_wad3_create(const char* path); // REQUIRES MANUAL FREE: vpkpp_close
VPKPP_API vpkpp_pack_file_handle_t vpkpp_wad3_open(const char* path, vpkpp_entry_callback_t callback); // REQUIRES MANUAL FREE: vpkpp_close
Expand Down
2 changes: 1 addition & 1 deletion lang/c/src/vpkppc/format/WAD3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ using namespace vpkpp;

const int8_t VPKPP_WAD3_FILENAME_MAX_SIZE = WAD3_FILENAME_MAX_SIZE;
const uint32_t VPKPP_WAD3_SIGNATURE = WAD3_SIGNATURE;
const std::string_view VPKPP_WAD3_EXTENSION = WAD3_EXTENSION.data();
const char* VPKPP_WAD3_EXTENSION = WAD3_EXTENSION.data();

VPKPP_API vpkpp_pack_file_handle_t vpkpp_wad3_create(const char* path) {
SOURCEPP_EARLY_RETURN_VAL(path, nullptr);
Expand Down
Loading