[DONT-MERGE-YET] Remove unnecessary dependencies in CMake.#8
Closed
zapolnov wants to merge 1 commit intocppfw:mainfrom
Closed
[DONT-MERGE-YET] Remove unnecessary dependencies in CMake.#8zapolnov wants to merge 1 commit intocppfw:mainfrom
zapolnov wants to merge 1 commit intocppfw:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 11 11
Lines 704 704
Branches 190 190
=======================================
Hits 485 485
Misses 192 192
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
As you can see, the I agree that it is not beautiful that we need to list all the transient dependencies, but vcpkg fro some reason does not work otherwise, I don't know how to fix it for now, I decided to leave it as is for now and don't spend much time figuring out how to improve it (if at all possible). Maybe sometime later, or maybe you know what is going on here... |
Member
|
fixed on main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.