use std::vector instead of std::list; why would you use a linked list?#27
Merged
ebcq merged 1 commit intocppdiscord:mainfrom May 5, 2026
Conversation
ebcq
approved these changes
May 5, 2026
Contributor
ebcq
left a comment
ebcq
left a comment
There was a problem hiding this comment.
Good catch! Using std::list definitely makes no sense here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a std::vector instead of a std::list; There is no real reason to use std::list instead of std::vector for the purpose of simply a constant storage of commands; Vector might even improve cache locality & speed.