TestThreadExecutor: inverted default quiet flag

Author: firewave

test/testthreadexecutor.cpp

@@ -49,7 +49,7 @@ class TestThreadExecutor : public TestFixture {
     struct CheckOptions
     {
         CheckOptions() DINIT_NOEXCEPT = default;
-        bool quiet = false;
+        bool quiet = true;
         SHOWTIME_MODES showtime = SHOWTIME_MODES::SHOWTIME_NONE;
         const char* plistOutput = nullptr;
         std::vector<std::string> filesList;
@@ -122,7 +122,7 @@ class TestThreadExecutor : public TestFixture {
 
         oss << "  return 0;\n"
             << "}\n";
-        check(2, 3, 3, oss.str(), true);
+        check(2, 3, 3, oss.str());
     }
 
     // TODO: check the output
@@ -132,7 +132,7 @@ class TestThreadExecutor : public TestFixture {
               "{\n"
               "  char *a = malloc(10);\n"
               "  return 0;\n"
-              "}", true);
+              "}");
     }
 
     // #11249 - reports TSAN errors - only applies to threads not processes though
@@ -144,7 +144,6 @@ class TestThreadExecutor : public TestFixture {
               "  char *a = malloc(10);\n"
               "  return 0;\n"
               "}", dinit(CheckOptions,
-                         $.quiet = true,
                          $.showtime = SHOWTIME_MODES::SHOWTIME_SUMMARY));
     }
 
@@ -158,7 +157,6 @@ class TestThreadExecutor : public TestFixture {
               "  char *a = malloc(10);\n"
               "  return 0;\n"
               "}", dinit(CheckOptions,
-                         $.quiet = true,
                          $.plistOutput = plistOutput));
     }
 
@@ -167,23 +165,23 @@ class TestThreadExecutor : public TestFixture {
               "int main()\n"
               "{\n"
               "  return 0;\n"
-              "}", true);
+              "}");
     }
 
     void no_errors_less_files() {
         check(2, 1, 0,
               "int main()\n"
               "{\n"
               "  return 0;\n"
-              "}", true);
+              "}");
     }
 
     void no_errors_equal_amount_files() {
         check(2, 2, 0,
               "int main()\n"
               "{\n"
               "  return 0;\n"
-              "}", true);
+              "}");
     }
 
     void one_error_less_files() {
@@ -192,7 +190,7 @@ class TestThreadExecutor : public TestFixture {
               "{\n"
               "  {char *a = malloc(10);}\n"
               "  return 0;\n"
-              "}", true);
+              "}");
     }
 
     void one_error_several_files() {
@@ -201,7 +199,7 @@ class TestThreadExecutor : public TestFixture {
               "{\n"
               "  {char *a = malloc(10);}\n"
               "  return 0;\n"
-              "}", true);
+              "}");
     }
 
     void markup() {