moved find_all_of() into cppcheck namespace and into helpers.h

Author: firewave

test/helpers.h

@@ -92,6 +92,19 @@ class PreprocessorHelper
     static std::string getcode(Preprocessor &preprocessor, const std::string &filedata, const std::string &cfg, const std::string &filename, Suppressions *inlineSuppression = nullptr);
 };
 
+namespace cppcheck {
+    template<typename T>
+    std::size_t find_all_of(const std::string& str, T sub) {
+        std::size_t n = 0;
+        std::string::size_type pos = 0;
+        while ((pos = str.find(sub, pos)) != std::string::npos) {
+            ++pos;
+            ++n;
+        }
+        return n;
+    }
+}
+
 /* designated initialization helper
     Usage:
     struct S

test/testthreadexecutor.cpp

@@ -244,17 +244,6 @@ class TestThreadExecutor : public TestFixture {
 
     // TODO: provide data which actually shows values above 0
 
-    template<typename T>
-    std::size_t find_all_of(const std::string& str, T sub) {
-        std::size_t n = 0;
-        std::string::size_type pos = 0;
-        while ((pos = str.find(sub, pos)) != std::string::npos) {
-            ++pos;
-            ++n;
-        }
-        return n;
-    }
-
     // TODO: should this be logged only once like summary?
     void showtime_top5() {
         REDIRECT;
@@ -263,7 +252,7 @@ class TestThreadExecutor : public TestFixture {
               true, SHOWTIME_MODES::SHOWTIME_TOP5);
         // for each file: top5 results + overall + empty line
         const std::string output_s = GET_REDIRECT_OUTPUT;
-        ASSERT_EQUALS((5 + 1 + 1) * 2, find_all_of(output_s, '\n'));
+        ASSERT_EQUALS((5 + 1 + 1) * 2, cppcheck::find_all_of(output_s, '\n'));
     }
 
     void showtime_file() {
@@ -272,7 +261,7 @@ class TestThreadExecutor : public TestFixture {
               "int main() {}",
               true, SHOWTIME_MODES::SHOWTIME_FILE);
         const std::string output_s = GET_REDIRECT_OUTPUT;
-        ASSERT_EQUALS(2, find_all_of(output_s, "Overall time:"));
+        ASSERT_EQUALS(2, cppcheck::find_all_of(output_s, "Overall time:"));
     }
 
     void showtime_summary() {
@@ -293,7 +282,7 @@ class TestThreadExecutor : public TestFixture {
               true, SHOWTIME_MODES::SHOWTIME_TOP5);
         // for each file: top5 results + overall + empty line
         const std::string output_s = GET_REDIRECT_OUTPUT;
-        ASSERT_EQUALS((5 + 1 + 1) * 2, find_all_of(output_s, '\n'));
+        ASSERT_EQUALS((5 + 1 + 1) * 2, cppcheck::find_all_of(output_s, '\n'));
     }
 
     void showtime_file_j() {
@@ -302,7 +291,7 @@ class TestThreadExecutor : public TestFixture {
               "int main() {}",
               true, SHOWTIME_MODES::SHOWTIME_FILE);
         const std::string output_s = GET_REDIRECT_OUTPUT;
-        ASSERT_EQUALS(2, find_all_of(output_s, "Overall time:"));
+        ASSERT_EQUALS(2, cppcheck::find_all_of(output_s, "Overall time:"));
     }
 
     void showtime_summary_j() {