-
Notifications
You must be signed in to change notification settings - Fork 192
TIFF: update to v4.7.0-p0 #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unpinn OpenCV 4.10 because TIFF 4.7.0 fixes build issues on Linux. Fixes: #765 Remove old `FindTIFF.cmake` module. Not needed anymore (and probably wasn't needed for a long time). Update to use https://github.com/cpp-pm/libtiff/releases/tag/v4.7.0-p0 hunterized dependencies: - `zlib`: default ON, only dependency available in previous 4.0.2 hunterized version) - `libdeflate`: default: ON, available in Hunter starting with `v0.26.3` #804 - `jpeg`: default OFF, newly hunterized - `lzma`: default OFF, newly hunterized Not hunterized dependencies: - `jbig=OFF` - `lerc=OFF` - `webp=OFF` Fixes: #789
|
FYI @TheNetos I've seen you've also worked on hunterizing TIFF v4.7.0. I hope this version fits your needs as well |
|
Hello! Unfortunately, in my case, i will need all dependencies except |
|
So only missing one would be The other dependencies (as listed above) can be enabled in the client-project |
|
Well, for now we have 2 non-hunterized packages and 1 cyclic dependency:
The biggest problem at the moment is the interdependence of |
|
I think you need to choose which one of the packages you want to use as interface. I know for a fact that you can build TIFF without webp. I assume (not checked) the same for webp. Then you could decide to use tiff, build it with webp support, and configure webp to build without TIFF. or you build both of them separately and a common parent decides which library to use. This is the case for the OpenCV build on Hunter: TIFF is built without WebP and WebP built without TIFF. Then OpenCV uses both as for lerc and jbig, I'll happily create a fork at cpp-pm if you point me to the needed upstream repos. Just create a package request issue at cpp-pm/hunter for each of them and we can coordinate there. |
Unpinn OpenCV 4.10 because TIFF 4.7.0 fixes build issues on Linux. Fixes: #765
Remove old
FindTIFF.cmakemodule. Not needed anymore (and probably wasn't needed for a long time).Update to use https://github.com/cpp-pm/libtiff/releases/tag/v4.7.0-p0
hunterized dependencies:
zlib: default ON, only dependency available in previous 4.0.2 hunterized version)libdeflate: default: ON, available in Hunter starting withv0.26.3Add "libdeflate" package as dependency of OpenEXR 3.2.0 #804jpeg: default OFF, newly hunterizedlzma: default OFF, newly hunterizedzstd: default OFF, newly hunterizedNot hunterized dependencies:
jbig=OFFlerc=OFFwebp=OFFFixes: #789